Skip to content

Build/Test Tools: Mock the external HTTP request in the get_theme_feature_list() test. #13605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adimoldovan wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Build/Test Tools: Mock the external HTTP request in the get_theme_feature_list() test. #13605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ce9ce6
Build/Test Tools: Mock the external HTTP request in the `get_theme_fe…
adimoldovan Sep 18, 2026
bee24b8
Merge branch 'trunk' into 63914-admin-includes-theme
adimoldovan Sep 18, 2026
bcdcfd2
Remove a redundant assertion and update the test description.
adimoldovan Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions tests/phpunit/tests/admin/includesTheme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,52 @@ public function test_page_templates_child_theme() {
}

/**
* Test that the list of theme features pulled from the WordPress.org API returns the expected data structure.
* Test that a mocked WordPress.org API response returns the expected translated list of theme features.
*
* Differences in the structure can also trigger failure by causing PHP notices/warnings.
*
* @group external-http
* @ticket 28121
*/
public function test_get_theme_featured_list_api() {
wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );

add_filter(
'pre_http_request',
static function () {
return array(
'headers' => array(),
'body' => wp_json_encode(
array(
'Subject' => array( 'blog', 'news' ),
'Features' => array( 'custom-logo', 'unknown-feature' ),
'Layout' => array( 'one-column' ),
)
),
'response' => array(
'code' => 200,
'message' => 'OK',
),
'cookies' => array(),
'filename' => null,
);
}
);

$featured_list_api = get_theme_feature_list( true );
$this->assertNonEmptyMultidimensionalArray( $featured_list_api );
$this->assertSame(
array(
'Subject' => array(
'blog' => 'Blog',
'news' => 'News',
),
'Features' => array(
'custom-logo' => 'Custom Logo',
'unknown-feature' => 'unknown-feature',
),
'Layout' => array(
'one-column' => 'One Column',
),
),
$featured_list_api
);
}

/**
Expand Down
Loading