Conversation
sirreal
commented
Sep 18, 2026
sirreal
commented
Sep 18, 2026
sirreal
marked this pull request as ready for review
September 18, 2026 11:24
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When a document ends in `<`, `<!`, or `<!-` and no further `<!--` follows, `WP_Block_Processor::next_token()` reports a block delimiter which is not in the document. `next_delimiter()` returns true for it, `opens_block()` is true, and the reported name, attributes, and delimiter type repeat the previous delimiter, or the uninitialized defaults when there was no previous delimiter. The open-block stack also gains an entry which is never popped. The branch which handles a missing `<!--` emits the preceding HTML span with `matched_delimiter_at` set before the end of the document, because the trailing partial is measured into the span's length. The re-entry at the top of `next_token()` only completes when `matched_delimiter_at` reaches the end, so it promotes the HTML span to a matched delimiter instead. Record the incomplete input when the span is emitted. The guard at the top of `next_token()` then stops the promotion, and the existing reporting of `INCOMPLETE_INPUT` is preserved.
sirreal
force-pushed
the
fix/block-processor-trailing-partial-comment
branch
from
September 18, 2026 11:28
a58d436 to
cdd5542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop
WP_Block_Processorfrom reporting an extra block delimiter when HTML content ends in<,<!, or<!-.For example,
<!-- wp:a -->text<makesnext_delimiter()reportcore/atwice. With no previous delimiter,text<reports a delimiter with an empty block name.The processor returns the final HTML span but then treats the trailing bytes as a delimiter, reusing the previous delimiter's state. Set
INCOMPLETE_INPUTwhen returning that span so the next call stops parsing. The example then produces onecore/adelimiter and an HTML span;next_token()returns false on the following call.Ten test cases cover the three partial comment prefixes, preceding opening, void and closing delimiters, and two complete-input controls. Eight cases fail before the fix. Local validation passed: 232
block-processortests and 633blockstests.Trac ticket: https://core.trac.wordpress.org/ticket/66138
Use of AI Tools
AI assistance: Yes
Tools: Claude Code, Codex
Models: Claude Opus, GPT-6
Used for: Finding the defect, drafting the fix and tests, and editing this description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.