Conversation
The inline documentation standards require an `@since` tag on every function and method. These eleven have complete `@param`/`@return` documentation but no `@since` at all, so the handbook reference pages for them show no version. Three are public HTML API methods: `WP_HTML_Tag_Processor::release_bookmark()` has been undocumented since it shipped in 6.2.0. Each version was determined from the commit that introduced the function, cross-checked against the previous release branch to confirm the function was not present there: * `WP_REST_Block_Directory_Controller::register_routes()` 5.5.0 * `WP_Sitemaps_Stylesheet::render_stylesheet()` 5.5.0 * `WP_HTML_Tag_Processor::release_bookmark()` 6.2.0 * `WP_REST_Font_Families_Controller::prepare_font_face_links()` 6.5.0 * `WP_Token_Map::to_array()` 6.6.0 * `WP_HTML_Tag_Processor::get_doctype_info()` 6.7.0 * `WP_HTML_Processor::get_namespace()` 6.7.0 * `WP_Block_Processor::is_block_type()` 6.9.0 * `WP_REST_Comments_Controller::check_post_type_supports_notes()` 6.9.0 * `WP_Theme_JSON::process_pseudo_selectors()` 7.0.0 * `wp_register_custom_css_support()` 7.0.0 See #65860.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| /** | ||
| * Registers the style block attribute for block types that support it. | ||
| * | ||
| * @since 7.0.0 |
There was a problem hiding this comment.
GB related changes need backport.
https://github.com/WordPress/gutenberg/blob/trunk/lib/block-supports/custom-css.php
cc. @t-hamano
There was a problem hiding this comment.
Thanks — backported in WordPress/gutenberg#83116
While checking the rest of this PR against Gutenberg lib/, WP_Theme_JSON::process_pseudo_selectors() turned out to be synced too (lib/class-wp-theme-json-gutenberg.php), so I included it in the same Gutenberg PR. The other nine functions here have no counterpart in lib/, so they should be core-only.
One thing worth a second opinion: lib/block-supports/custom-css.php has no @since tags at all today, so the Gutenberg side adds the first one to that file. lib/class-wp-theme-json-gutenberg.php already uses @since throughout, so that half is consistent either way. Happy to drop the custom-css.php change from both PRs if you would rather leave that file alone.
The Inline Documentation Standards require an
@sincetag on every function and method. These eleven have complete@param/@returndocumentation but no@sinceat all, so their handbook reference pages show no version at all.Three of them are public HTML API methods —
WP_HTML_Tag_Processor::release_bookmark()has been undocumented since it shipped in 6.2.0.@sinceWP_REST_Block_Directory_Controller::register_routes()WP_Sitemaps_Stylesheet::render_stylesheet()WP_HTML_Tag_Processor::release_bookmark()WP_REST_Font_Families_Controller::prepare_font_face_links()WP_Token_Map::to_array()WP_HTML_Tag_Processor::get_doctype_info()WP_HTML_Processor::get_namespace()WP_Block_Processor::is_block_type()WP_REST_Comments_Controller::check_post_type_supports_notes()WP_Theme_JSON::process_pseudo_selectors()wp_register_custom_css_support()How the versions were determined
For each function, the commit that first introduced it was found with
git log -Son its file, and the earliest release tag containing that commit was taken as the version. Each result was then cross-checked against the previous release branch (git show <prior tag>:<file>) to confirm the function was not already present there — for examplerelease_bookmark()is absent from6.1.12, andget_doctype_info()is absent from the6.6.7copy of a file that otherwise already existed.Each version also lines up with the release that introduced the surrounding feature: sitemaps and the block directory in 5.5, the HTML API in 6.2, the Font Library in 6.5,
WP_Token_Mapin 6.6, andWP_Block_Processorin 6.9.Testing
php -lclean on all ten changed files.git diff --checkclean.Trac ticket: https://core.trac.wordpress.org/ticket/65860
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Repository scanning to identify missing documentation tags, and drafting this change. Reviewed by me.