Conversation
`render_block_core_block()` is the render callback for the `core/block` block and receives three arguments, but its docblock only documented `$attributes`. `$content` and `$block_instance` were never documented, even though `$block_instance` is used in the function body to attach the referenced pattern's blocks as inner blocks and render them. The descriptions follow the wording used by the majority of core block render callbacks. The blank line between the `@param` block and `@return` is also removed, per the inline documentation standards. See #65860.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render_block_core_block()is the render callback registered for thecore/blockblock and receives three arguments, but its docblock only documented$attributes.$contentand$block_instancewere never documented, even though$block_instanceis used in the function body to attach the referenced pattern's blocks as inner blocks (parsed_block['innerBlocks']), refresh its context dependents, and render the result.The new descriptions follow the wording used by the majority of core block render callbacks (
Block default content.andBlock instance., which are the most common phrasings insrc/wp-includes/blocks/), and the@paramblock is aligned. The blank line between the@paramblock and@returnis also removed, per the Inline Documentation Standards.Testing
php -lclean on the changed file.Trac ticket: https://core.trac.wordpress.org/ticket/65860
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Repository scanning to identify potential documentation/signature inconsistencies, and drafting this change. Reviewed by me.