Skip to content

Try to make the media grid toolbar height flexible. #13583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afercia wants to merge 1 commit into
base: trunk
Choose a base branch
from
+45 −21
Open

Try to make the media grid toolbar height flexible. #13583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/wp-admin/css/list-tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,7 @@ th.sorted a span {

.media-toolbar.wp-filter .view-switch {
margin: 0 12px 0 2px;
padding: 0;
}

.view-switch a {
Expand Down
3 changes: 2 additions & 1 deletion src/wp-admin/css/media.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ border color while dragging a file over the uploader drop area */
flex-wrap: wrap;
align-items: center;
gap: 8px;
padding: 0 !important; /* Override potential padding added by plugins. */
}

.media-frame.mode-grid.mode-edit .media-toolbar-secondary > .select-mode-toggle-button {
Expand All @@ -619,7 +620,7 @@ border color while dragging a file over the uploader drop area */
}

.media-frame-content .media-search-input-label {
vertical-align: baseline;
margin-bottom: 4px;
}

.attachments-browser .media-toolbar-secondary > .media-button {
Expand Down
62 changes: 42 additions & 20 deletions src/wp-includes/css/media-views.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,20 +297,14 @@
* Toolbar
*/
.media-toolbar {
position: absolute;
top: 0;
left: 0;
right: 0;
z-index: 100;
height: 48px;
padding: 0 16px;
border: 0 solid #dcdcde;
overflow: auto;
}

.media-frame-toolbar .media-toolbar {
top: auto;
bottom: -60px;
bottom: 0;
height: auto;
overflow: visible;
border-top: 1px solid #dcdcde;
Expand All @@ -330,16 +324,26 @@
}

.media-toolbar-secondary {
float: left;
height: 100%;
width: auto !important; /* override potential width added by plugins */
display: grid;
grid-template-columns: repeat( 2, 1fr );
grid-template-rows: repeat( 2, 1fr );
grid-column-gap: 12px;
grid-row-gap: 0px;
/* grid-template-rows: repeat( 2, 1fr ); */
grid-column-gap: 8px;
grid-row-gap: 8px;
align-items: end;
}

.media-frame .media-toolbar-secondary label {
margin-bottom: -4px;
}

/* Reset styles from the FOlders plugin for testing purposes */
.media-frame .media-toolbar-secondary select {
width: auto !important;
margin: 0 !important
}

label[for="media-attachment-filters"] {
grid-area: 1 / 1 / 2 / 2;
}
Expand Down Expand Up @@ -787,7 +791,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
* Frame
*/
.media-frame {
overflow: hidden;
overflow: hidden !important; /* !important for debugging purposes to override overflow: inherit; from the Folder plugins. */
position: absolute;
top: 0;
left: 0;
Expand Down Expand Up @@ -831,7 +835,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
height: auto;
width: auto;
margin: 0;
overflow: auto;
overflow: auto !important; /* !important for debugging purposes to override overflow: inherit; from the Folder plugins. */
background: #fff;
border-top: 1px solid #dcdcde;
}
Expand All @@ -841,7 +845,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
left: 200px;
right: 0;
z-index: 100;
bottom: 60px;
bottom: 0;
height: auto;
}

Expand Down Expand Up @@ -957,7 +961,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
min-height: 32px;
line-height: 2.14285714; /* 30px for 32px height with 14px font */
padding: 0 24px 0 8px;
margin-right: 2%;
margin-right: 0;
}

.media-frame select.attachment-filters:last-of-type {
Expand Down Expand Up @@ -1248,16 +1252,34 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
* Attachments Browser
*/
.media-frame .attachments-browser {
position: relative;
width: 100%;
display: flex;
flex-direction: column;
align-items: flex-start;
height: 100%;
overflow: hidden;
}

.attachments-wrapper {
position: relative;
flex: 1;
overflow-y: auto;
min-width: 100%;
background: lightcoral; /* temporary background color for debugging */
}

.attachments-browser .media-toolbar {
right: 300px;
background: #fff;
padding: 12px 16px;
display: flex;
justify-content: space-between;
background: lightblue; /* temporary background color for debugging */
}

.media-modal .attachments-browser .media-toolbar {
position: sticky;
top: 0;
z-index: 100;
min-width: calc(100% - 300px);
box-sizing: border-box;
}

.attachments-browser.hide-sidebar .media-toolbar {
Expand All @@ -1279,7 +1301,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
.attachments-browser.has-load-more .attachments-wrapper,
.attachments-browser .uploader-inline {
position: absolute;
top: 72px;
top: 0;
left: 0;
right: 300px;
bottom: 0;
Expand Down
Loading