Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This error is strikingly similar to the problem reported with wp-cli. wp-cli/wp-cli#6320 Consider using the nightly version of WP-CLI, or perhaps this issue will be resolved once a new version of WP-CLI is released. cc @swissspidy |
|
Yep need to update to WP-CLI nightly. Though we're really working on the next stable release, hopefully right after 7.1 ships. So stay put. btw shameless plug: swissspidy#96 |
|
Nice, focused addition. Placing verification immediately after download isolates archive and extraction problems well. One scalability question: this PR ran the checksum command 394 times, repeating the same WordPress/PHP check across database and multisite variants. Since extraction and checksum results should not depend on the database or multisite mode, could one representative job per WordPress/PHP pair provide the same signal with less WordPress.org API traffic and failure fan-out? This is non-blocking; the current failures appear to be the known WP-CLI 2.12.0 extraction defect rather than a problem with this patch. Adversarial review · |
lancewillett
left a comment
There was a problem hiding this comment.
This can land; I left a non-blocking suggestion.
There was a problem hiding this comment.
🟡 Changes recommended
The checksum verification queries unavailable release checksums for nightly WordPress downloads, causing default workflow jobs to fail before installation.
1 open issue
What changed in this PR
Adds WordPress checksum verification to the installation and upgrade test workflows, checking downloaded files before configuration and installation.
Changes:
- Adds
wp core verify-checksumsimmediately after downloading WordPress in both workflows. - Updates workflow comments to document the verification step.
| File | Description |
|---|---|
.github/workflows/reusable-upgrade-testing.yml |
Adds checksum verification before preparing WordPress for upgrade tests. |
.github/workflows/install-testing.yml |
Adds checksum verification before configuring and installing WordPress. |
Review effort: Balanced
| WP_VERSION: ${{ inputs.wp-version || 'nightly' }} | ||
|
|
||
| - name: Verify checksums | ||
| run: wp core verify-checksums |
lancewillett
left a comment
There was a problem hiding this comment.
Please refresh this against trunk and narrow the immediate change to installation verification, deferring the upgrade hunk until its WP-CLI dependency is verified.
The sampled upgrade failure reached the new checksum step and reported missing files and truncated paths. The check exposed an extraction defect. The upstream component fixes are merged, but their availability in the stable WP-CLI bundle used here is not established.
The installation check still has value: checking extracted files is distinct from archive MD5 validation. #15252 does not supersede that check or fix the upgrade workflow. After refresh, please verify a current release install and a nightly install. The earlier nightly job passed this checksum step, so the blanket claim that nightly cannot work is not supported by that run.
AI review · gpt-6

This adds a step to both the upgrade & installation test workflows to perform a checksum verification after downloading WordPress.
Trac ticket: Core-65845
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.