Skip to content

Formatting: Add strip_html_newlines() function#11450

Open
himanshupathak95 wants to merge 8 commits intoWordPress:trunkfrom
himanshupathak95:fix/5678
Open

Formatting: Add strip_html_newlines() function#11450
himanshupathak95 wants to merge 8 commits intoWordPress:trunkfrom
himanshupathak95:fix/5678

Conversation

@himanshupathak95
Copy link
Copy Markdown

@himanshupathak95 himanshupathak95 commented Apr 6, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/5678

This PR adds strip_html_newlines() to wp-includes/formatting.php, a function that strips unnecessary newlines from text nodes in fully marked-up HTML while preserving newlines inside pre, code, kbd, script, and style elements (maybe we can fix the hardcoding and think of something better later but keeping this simple for now)

This is useful for cleaning up imported HTML content before it is processed by wpautop(), which would otherwise convert superfluous newlines into unwanted <br /> elements.

Testing

npm run test:php -- --filter=Tests_Formatting_StripHtmlNewlines

Refreshing and inspired by the patch - https://core.trac.wordpress.org/attachment/ticket/5678/5678.r6633.diff
Props @hansengel

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95 himanshupathak95 marked this pull request as ready for review April 7, 2026 14:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant