Repository navigation
Address the review notes from the 7.2 Beta 5 core commit - #216
Merged
Merged
Conversation
The front end picks style.min.css with a plain SCRIPT_DEBUG check, as Twenty Twenty-Five does, and style.css carries the same note against editing it in the Theme File Editor. Template descriptions say the theme header and footer, and the presets docblock says what happens when the presets aren't an array. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows up on Peter Wilson's review of the 7.2 Beta 5 sync, WordPress/wordpress-develop#15845. He asked for these to be fixed here, so core and Ipsum stay in step.
style.min.csswith a plainSCRIPT_DEBUGcheck, as Twenty Twenty-Five does, instead of comparing file times. Theme directory uploads use the ZIPs from wordpress-develop's build, which include the minified file.style.cssgets Twenty Twenty-Five's note against editing it in the Theme File Editor.ipsum_get_design_guide_presets()docblock says what happens when the presets aren't an array: you get an empty list.Testing Instructions
SCRIPT_DEBUGon as in wp-env,<style id="ipsum-style-inline-css">holdsstyle.css. Runnpm run wp-env -- run cli wp config set SCRIPT_DEBUG false --rawand reload: it holds the minified CSS./wp-json/wp/v2/block-patterns/patternsand check that the template descriptions name the theme header and footer.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Making the changes from the review, checking them and this description.
🤖 Generated with Claude Code