Skip to content

Address the review notes from the 7.2 Beta 5 core commit - #216

Merged
juanfra merged 1 commit into
trunkfrom
update/beta-5-review-notes
Nov 10, 2026
Merged

juanfra merged 1 commit into
trunkfrom
update/beta-5-review-notes

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Description

Follows up on Peter Wilson's review of the 7.2 Beta 5 sync, WordPress/wordpress-develop#15845. He asked for these to be fixed here, so core and Ipsum stay in step.

  • The front end picks style.min.css with a plain SCRIPT_DEBUG check, as Twenty Twenty-Five does, instead of comparing file times. Theme directory uploads use the ZIPs from wordpress-develop's build, which include the minified file. style.css gets Twenty Twenty-Five's note against editing it in the Theme File Editor.
  • Template descriptions say "the theme header" and "the theme footer", as he suggested for the 404 template, and the Search Bar part's description matches.
  • The ipsum_get_design_guide_presets() docblock says what happens when the presets aren't an array: you get an empty list.

Testing Instructions

  1. On the front end, with SCRIPT_DEBUG on as in wp-env, <style id="ipsum-style-inline-css"> holds style.css. Run npm run wp-env -- run cli wp config set SCRIPT_DEBUG false --raw and reload: it holds the minified CSS.
  2. Open /wp-json/wp/v2/block-patterns/patterns and check that the template descriptions name the theme header and footer.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Making the changes from the review, checking them and this description.

🤖 Generated with Claude Code

The front end picks style.min.css with a plain SCRIPT_DEBUG check, as Twenty Twenty-Five does, and style.css carries the same note against editing it in the Theme File Editor. Template descriptions say the theme header and footer, and the presets docblock says what happens when the presets aren't an array.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions github-actions Bot added documentation Improvements or additions to documentation [Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. [Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php. labels Nov 10, 2026

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@juanfra
juanfra merged commit 08cc61d into trunk Nov 10, 2026
8 checks passed
@juanfra
juanfra deleted the update/beta-5-review-notes branch November 10, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. [Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants