Skip to content

Project Management: Exclude PHPStan config and baseline from CODEOWNERS - #86112

Merged
manzoorwanijk merged 1 commit into
trunkfrom
chore/codeowners-exclude-phpstan-config
Nov 1, 2026
Merged

manzoorwanijk merged 1 commit into
trunkfrom
chore/codeowners-exclude-phpstan-config

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Member

What?

Follow up to #82538 and #82750. Adds tools/phpstan/base.neon and tools/phpstan/baseline.neon to the Exclusions section at the end of .github/CODEOWNERS.

Why?

This reduces the noise from review requests. Like the lint suppression lists, these files change as a side effect of unrelated work. Each PHPStan fix removes entries from the baseline (e.g. #86090, #86096). Without an exclusion, /tools sends a review request for each such change.

How?

Adds the two paths, without an owner, to the existing Exclusions section. Last match wins, so they override /tools.

Testing Instructions

  1. Open a PR that changes tools/phpstan/baseline.neon.
  2. Make sure that no review is requested for it.

Use of AI Tools

Claude Code, to add the entries and draft this description. Reviewed by me.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

@manzoorwanijk
manzoorwanijk force-pushed the chore/codeowners-exclude-phpstan-config branch from e652341 to 901eaea Compare November 1, 2026 04:13
@manzoorwanijk manzoorwanijk added the [Type] Project Management Meta-issues related to project management of Gutenberg label Nov 1, 2026
@manzoorwanijk manzoorwanijk self-assigned this Nov 1, 2026
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review November 1, 2026 04:15
@manzoorwanijk
manzoorwanijk merged commit 4be943c into trunk Nov 1, 2026
82 checks passed
@manzoorwanijk
manzoorwanijk deleted the chore/codeowners-exclude-phpstan-config branch November 1, 2026 09:08
@github-actions github-actions Bot added this to the Gutenberg 24.4 milestone Nov 1, 2026
@aduth

aduth commented Nov 2, 2026

Copy link
Copy Markdown
Member

cc for awareness @westonruter following #66598 and related to #86088, in case you or another have interest in code ownership over these .neon files (for awareness to fixes relating to #86088) or the broader PHPStan-related files.

@westonruter

Copy link
Copy Markdown
Member

cc for awareness @westonruter following #66598 and related to #86088, in case you or another have interest in code ownership over these .neon files (for awareness to fixes relating to #86088) or the broader PHPStan-related files.

Thanks. I've opened #86204 to add myself as code owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Project Management Meta-issues related to project management of Gutenberg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants