Repository navigation
chore: remove duplicate code in WP_Theme_JSON_Gutenberg::get_block_nodes() - #68400
justlevine wants to merge 1 commit into
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
60531c0 to
4971402
Compare
What?
This PR removes a duplicate logical path for
$include_node_paths_onlyinsideWP_Theme_JSON_Gutenberg::get_block_nodes(), as this logic is already handled with acontinuea few lines up in the loop spaghetti.Why?
While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast