Skip to content

chore: remove duplicate code in WP_Theme_JSON_Gutenberg::get_block_nodes() - #68400

Closed
justlevine wants to merge 1 commit into
WordPress:trunkfrom
justlevine:chore/dead-code_get_block_nodes()
Closed

justlevine wants to merge 1 commit into
WordPress:trunkfrom
justlevine:chore/dead-code_get_block_nodes()

Conversation

@justlevine

@justlevine justlevine commented Dec 30, 2024 •

Copy link
Copy Markdown
Contributor

What?

This PR removes a duplicate logical path for $include_node_paths_only inside WP_Theme_JSON_Gutenberg::get_block_nodes(), as this logic is already handled with a continue a few lines up in the loop spaghetti.

Why?

While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@justlevine
justlevine force-pushed the chore/dead-code_get_block_nodes() branch from 60531c0 to 4971402 Compare April 18, 2025 23:00
@westonruter

Copy link
Copy Markdown
Member

Closing since the deleted code was already deleted in 102eb74 (#81291).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants