[justlevine]

What?

This PR fixes the PHPDoc return type for gutenberg_get_typography_value_and_unit() to correctly indicate it may return null.

Why?

While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before	After

[westonruter]

🤖 Comment by Claude Opus 5.5

Trunk was merged in, and 54b0ed2 changes the @return from ?array to array|null, with core's description ("… on success. null on failure."). This matches wp_get_typography_value_and_unit() in core, which has documented the return this way since r54260. Only the @return tag is synced, since core has since reworked the function body, so its @phpstan-* shapes and native ?array return type would not describe this implementation.

This resolves the three return.type errors reported at PHPStan level 5, with none introduced. Since core already documents the return correctly, the No Core Sync Required label was added.

[github-actions]

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

[westonruter]

🤖 Comment by Claude Opus 5.5

Rather than syncing only the @return tag, c0ba7b1 now syncs the whole function with wp_get_typography_value_and_unit() as it stands in core after r62719 (Core-65143). That change parses the value and unit with a fixed regular expression and then checks the unit against the acceptable units with in_array(), instead of interpolating the units into the pattern unescaped. It also casts the value to a float and adds @phpstan-* shapes and a native ?array return type. The function is now identical to core's apart from the prefix and text domain, and WP_Block_Supports_Typography_Test passes. The label was changed to Backport from WordPress Core accordingly.

[westonruter]

The only difference between the functions now:

--- core.txt	2026-10-25 13:30:54
+++ gutenberg.txt	2026-10-25 13:30:38
@@ -21,11 +21,11 @@
  * } $options
  * @phpstan-return array{ value: float, unit: non-empty-string }|null
  */
-function wp_get_typography_value_and_unit( $raw_value, $options = array() ): ?array {
+function gutenberg_get_typography_value_and_unit( $raw_value, $options = array() ): ?array {
 	if ( ! is_string( $raw_value ) && ! is_int( $raw_value ) && ! is_float( $raw_value ) ) {
 		_doing_it_wrong(
 			__FUNCTION__,
-			__( 'Raw size value must be a string, integer, or float.' ),
+			__( 'Raw size value must be a string, integer, or float.', 'gutenberg' ),
 			'6.1.0'
 		);
 		return null;