Repository navigation
feat: make SMTP AUTH mechanism selectable per channel - #347
Merged
Merged
Conversation
The outbound SMTP channel always authenticated with AUTH PLAIN, so servers that only offer LOGIN (Office 365/Exchange, many hosting providers) or CRAM-MD5 could not be used. Add an `smtp_auth_method` channel setting: - auto (default, also used for existing channels): pick the first of PLAIN, LOGIN, CRAM-MD5 advertised by the server in EHLO, falling back to PLAIN when nothing is advertised (previous behavior) - plain / login / cram-md5: force a mechanism, with a clear error when the server does not advertise it - none: never authenticate, even if credentials are stored AUTH LOGIN is implemented locally since net/smtp does not provide it. All mechanisms refuse to send credentials over an unencrypted connection, and unknown values are rejected by ValidateTransport. The channel config UI gets an "Authentication method" selector, with translations for the required locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
needed to auth mail on office365 so i've used claude to make this. seems pretty straight forward as a patch. Deployed on my instance at work (i'm setting up windshift to be used). |
stefan-ernst
self-requested a review
October 16, 2026 15:00
Contributor
|
Looks good, merging this in for the next release as it features a lot new email features that will be usable right away with o365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outbound SMTP channel always authenticated with AUTH PLAIN, so servers that only offer LOGIN (Office 365/Exchange, many hosting providers) or CRAM-MD5 could not be used.
Add an
smtp_auth_methodchannel setting:AUTH LOGIN is implemented locally since net/smtp does not provide it. All mechanisms refuse to send credentials over an unencrypted connection, and unknown values are rejected by ValidateTransport.
The channel config UI gets an "Authentication method" selector, with translations for the required locales.