Skip to content

feat(frontend): enhance command palette to support external links #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-ernst merged 1 commit into from
Oct 13, 2026
Merged

feat(frontend): enhance command palette to support external links #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions frontend/src/lib/layout/CommandPalette.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import { api } from '../api.js';
import { contextCommands } from '../utils/contextCommands.js';
import { currentRoute } from '../router.js';
import { toExternal } from '../runtime/contextPath.js';
import { permissionStore, workspacesStore, isSystemAdmin, currentWorkspace } from '../stores';
import { moduleSettings } from '../stores/moduleSettings.js';
import { timerStore } from '../stores/timerStore.svelte.js';
Expand Down Expand Up @@ -226,6 +227,14 @@
}
}

// Rows with a url are real links: modified and middle clicks fall through to
// the browser so the target can open in a new tab.
function handleOptionClick(e, cmd) {
if (cmd.url && (e.metaKey || e.ctrlKey || e.shiftKey || e.altKey || e.button !== 0)) return;
e.preventDefault();
executeAndClose(cmd);
}

function close() {
isOpen = false;
open.set(false);
Expand Down Expand Up @@ -367,11 +376,13 @@
{BUCKET_LABELS[command.bucket] || ''}
</div>
{/if}
<div
<svelte:element
this={command.url ? 'a' : 'div'}
href={command.url ? toExternal(command.url) : undefined}
use:melt={$option({ value: command.id, label: command.label })}
onclick={() => executeAndClose(command)}
onclick={(e) => handleOptionClick(e, command)}
data-testid={`command-palette-option-${command.id}`}
class="w-full text-left px-4 py-2.5 transition-colors cursor-pointer command-option"
class="block w-full text-left px-4 py-2.5 transition-colors cursor-pointer no-underline command-option"
>
<div class="flex items-center gap-2">
<div class="font-medium" style="color: var(--ds-text);">{command.label}</div>
Expand All @@ -384,7 +395,7 @@
{#if command.description}
<div class="text-sm mt-0.5" style="color: var(--ds-text-subtle);">{command.description}</div>
{/if}
</div>
</svelte:element>
{/each}
</div>
{/if}
Expand Down
Loading