Repository navigation
fix: accept "canceled" for planning statuses at the API boundary - #310
Merged
stefan-ernst merged 2 commits intoOct 5, 2026
Merged
Conversation
The API only accepts "cancelled" for milestones (planning_validation.go), but `ws milestone ls --status` documented "canceled", so filtering by the documented value matched nothing. Show the persisted spelling in the --status help of ls, create and update, and map "canceled" to "cancelled" before sending, so both spellings work.
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Normalize the US spelling at the planning service boundary so milestone and iteration create, update, list, and status-set calls accept either spelling. This covers the v1/v2 HTTP APIs, MCP tools, and the ws CLI. The ws CLI drops its own translation and documents the canonical value.
stefan-ernst
changed the title
Contributor
|
Moved the check to the API surface to keep it consistent for other tool calls, thanks for the PR! merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The planning API now accepts both spellings for milestone and iteration statuses:
canceled(US) andcancelled(UK, persisted). The service boundary normalizescanceledtocancelledbefore validation, filtering, and storage, so the v1/v2 HTTP APIs, MCP tools, and the ws CLI all behave the same.The ws CLI no longer carries its own translation; it documents and sends the canonical value.
Why
The API only matched
cancelled, so--status canceled(the value the CLI help previously advertised) filtered to nothing and failed create/update validation. Users type either spelling, so the alias belongs at the API boundary where every client benefits.Tests
internal/services/planning_status_canceled_spelling_test.go: create, list, update, and status-set paths for milestones and iterations.tests/v2_planning_status_alias_test.go: v2 HTTP endpoints, including invalid status rejection.Both live in the adjacent core-tests repository on branch
fix/ws-milestone-cancelled-status.