Fix/2026 backend followup improvements - #144
Merged
Merged
Conversation
- Fix NameError in get_reservation_resolver when DbSession raises - Fix fetch_reservation and delete_reservation type hints (id builtin → int) - Remove unreachable else branch in delete_reservation - Fix getReservation schema argument (roomId → id) - Replace deprecated datetime.utcnow() with datetime.now(timezone.utc) - Remove unused create_refresh_token - Add default for ENV and startup validation for required secrets - Fix convert_to_local_date_from_str dropping timezone conversion on naive datetime - Remove unused find_by_id spec helper and normalize test method naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix backend bugs and dead code from follow-up review