Fix/may 2026 code review findings - #143
Merged
Merged
Conversation
- Fix CORS misconfiguration (wildcard origin + allow_credentials) - Fix fetch_available_rooms iterating dict keys instead of rooms - Fix double-decrement in sharedReducer on API error - Fix *_FAILED action type strings duplicating *_SUCCESS values - Fix DummyPool missing execute method - Fix deprecated datetime.utcnow() in auth - Fix swallowed token fetch error in baseApi - Fix createComponentReducer mutating caller's actionHandlers - Clean up settings.py duplicate declarations - Rename connectComponent config key dispatch -> mapDispatchToProps - Fix typos in cancellation dialog strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address full-stack code review findings: