chore: willboosterify this repo#171
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Yarn version from 4.14.1 to 4.15.0 and bumps the @willbooster/wb dependency to 13.16.0. Feedback indicates that the yarnPath setting in .yarnrc.yml is redundant and potentially broken as the corresponding binary was not included in the changes. Additionally, the manual update to the lockfile version in yarn.lock is flagged as inconsistent; it is recommended to revert this manual edit and allow Yarn to update the file automatically to ensure integrity.
| spec: 'https://github.com/WillBooster/yarn-plugin-auto-install/releases/download/v2.0.7/index.cjs' | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.14.1.cjs | ||
| yarnPath: .yarn/releases/yarn-4.15.0.cjs |
There was a problem hiding this comment.
The yarnPath setting is redundant because the Yarn version is already specified in the packageManager field of package.json (line 85). Modern Yarn 4 projects should rely on Corepack to manage the version. Furthermore, the specified file .yarn/releases/yarn-4.15.0.cjs is not included in this pull request, which will cause Yarn commands to fail. It is recommended to remove this line and the associated binary to simplify the repository and follow modern practices.
References
- Simplify code as much as possible to eliminate redundancy. (link)
|
|
||
| __metadata: | ||
| version: 9 | ||
| version: 10 |
There was a problem hiding this comment.
The lockfile version has been manually updated to 10, but the cacheKey and other package checksums remain unchanged. This suggests an inconsistent manual edit, which is discouraged as it can lead to build issues. Please revert this manual change and allow Yarn to update the lockfile automatically by running yarn install after updating the packageManager in package.json.
1 participant
No description provided.