Repository navigation
organisations: Sync user lists by diff, not clear and re-add - #475
Open
theresnotime wants to merge 1 commit into
Open
theresnotime wants to merge 1 commit into
theresnotime wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
users_update_listscleared each organisation's username list andadded all users again every hour. Each run used new ids in the join
table. This used all of the 32-bit id space.
Now the command compares the API list with the stored list. It adds
only the new users and removes only the missing users. A run with no
changes adds no rows.
Also:
exception. One bad organisation does not stop the batch.
list.
username_list_updatedonly after a sync is successful.Assisted-by: Claude Opus 5.5
Bug: T434714