Repository navigation
Remove one-time survey code - #1571
Open
Samwalton9 wants to merge 1 commit into
Open
Samwalton9 wants to merge 1 commit into
Samwalton9 wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes code we wrote for a one-time user survey sent a year ago. We have no near-term plans to send more of these, so I set out primarily to remove the db column and the localisable strings, along with any code associated to this one-time survey. I didn't remove everything, though, and left the email backend and env variables because they were generic and could be used for future mediawiki API emails.
See https://github.com/WikipediaLibrary/TWLight/pull/1497/changes and https://github.com/WikipediaLibrary/TWLight/pull/1498/changes for the direct comparison of what was added.
Definitely open to the idea of removing more or less than I have here, I wasn't 100% sure I got the balance right.
Rationale
Removes unused code; drops some unnecessary data; reduces translator burden.
Phabricator Ticket
https://phabricator.wikimedia.org/T441242
How Has This Been Tested?
Ran tests; clicked around site locally and verified nothing appeared broken.
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: