Fix/#197 구글 Ads OAuth 연동 이후 콜백 URL 설정 - #210
Open
jinnieusLab wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughGoogle Ads OAuth 프론트엔드 콜백 URL을 환경 변수와 애플리케이션 설정으로 분리했습니다. Docker Compose와 CI가 해당 변수를 전달합니다. OAuth 컨트롤러는 전용 Google Ads 설정을 사용합니다. ChangesGoogle Ads 콜백 설정
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kingmingyu
requested changes
Aug 3, 2026
kingmingyu
left a comment
Collaborator
There was a problem hiding this comment.
P1: 고생하셨어요! ci랑 yml에 추가된 거 확인했습니다! 추가로 docker-compose.yml에도 추가해야할 것 같아요!
Member
Author
넵 추가하였습니다! |
kingmingyu
self-requested a review
August 4, 2026 06:41
kingmingyu
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🚀 개요
구글 Ads 플랫폼 연동 성공 후 Access Token 관련 쿠키가 세팅되지 않은 채 로그인 전용 리다이렉트 URL(
/oauth2/redirect)로 이동해, 프론트가 미로그인 상태로 로그인 화면으로 튕기던 문제를 수정했습니다.📄 작업 내용
GoogleAdOAuthController가 로그인 성공 리다이렉트용 프로퍼티(oauth2.redirect-url)를 재사용하던 부분을 제거하고, Google Ads 연동 전용 프론트 콜백 프로퍼티(google.ads.frontend-callback-url)를 새로 참조하도록 변경application.yml에google.ads.frontend-callback-url설정 추가 (GOOGLE_ADS_FRONTEND_CALLBACK_URL환경변수로 주입)META_FRONTEND_CALLBACK_URL→/oauth2/meta/result)과 동일한 패턴으로, 로컬 기본값을http://localhost:5173/oauth2/google/result로 설정.env.example, 노션 환경 변수 페이지에GOOGLE_ADS_FRONTEND_CALLBACK_URL항목 업데이트📸 스크린샷 / 테스트 결과 (선택)
✅ 체크리스트
🔍 리뷰 포인트 (Review Points)
프론트의 수정 작업이 필요하기에, 머지 후 프론트에게 해당 url 전달 예정입니다!
Summary by CodeRabbit