Skip to content

perf(trans): limit custom source workflow reconciliation - #22371

Merged
nijel merged 1 commit into
mainfrom
worflow-work
Oct 25, 2026
Merged

nijel merged 1 commit into
mainfrom
worflow-work

Conversation

@nijel

@nijel nijel commented Oct 25, 2026

Copy link
Copy Markdown
Member

Reduce synchronous workflow saves to affected languages and their dependants instead of rebuilding every translation in the project. Batch translation memory updates and deduplicate peer checks while preserving atomic reconciliation.

Reduce synchronous workflow saves to affected languages and their dependants instead of rebuilding every translation in the project. Batch translation memory updates and deduplicate peer checks while preserving atomic reconciliation.
@nijel nijel added this to the 2026.11 milestone Oct 25, 2026
@nijel nijel self-assigned this Oct 25, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T16:23:32.368430Z e679ed2 PR opened
🔒 Security Review ✅ Completed 2026-10-25T16:26:34.580319Z e679ed2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nijel
nijel enabled auto-merge (rebase) October 25, 2026 16:25
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13424 1 13423 846
View the top 1 failed test(s) by shortest run time
weblate.trans.tests.test_models.TranslationTest::test_commit_policy
Stack Traces | 0.774s run time
self = <weblate.trans.tests.test_models.TranslationTest testMethod=test_commit_policy>

    def test_commit_policy(self) -> None:
        component = self.create_xliff()
        translation = component.translation_set.get(language_code="cs")
        user = create_test_user()
    
        project = component.project
        project.commit_policy = CommitPolicyChoices.APPROVED_ONLY
        project.translation_review = True
        project.save()
    
        self.assertIn("approved", project.get_commit_policy_description())
    
        unit1 = translation.unit_set.get(source="Hello, world!\n")
        unit1.translate(user, "Unit 1 - Test 1", STATE_TRANSLATED)
        unit1.translate(user, "Unit 1 - Test 2", STATE_FUZZY)
        unit1.translate(user, "Unit 1 - Test 3", STATE_APPROVED)
        unit1.translate(user, "Unit 1 - Test 4", STATE_FUZZY)
    
        unit2 = translation.unit_set.get(source="Thank you for using Weblate.")
        unit2.translate(user, "Unit 2 - Test 1", STATE_FUZZY)
    
        unit3 = translation.unit_set.get(
            source="Try Weblate at &lt;https://demo.weblate.org/&gt;!\n"
        )
        unit3.translate(user, "Unit 3 - Test 1", STATE_TRANSLATED)
    
        self.assertEqual(PendingUnitChange.objects.count(), 6)
        changes = list(PendingUnitChange.objects.for_translation(translation))
        self.assertEqual(len(changes), 3)
        self.assertTrue(all(p.unit == unit1 for p in changes))
>       self.assertEqual(
            [STATE_TRANSLATED, STATE_FUZZY, STATE_APPROVED], [p.state for p in changes]
        )
E       AssertionError: Lists differ: [StringState.STATE_TRANSLATED, StringState[36 chars]OVED] != [10, 30, 20]
E       
E       First differing element 0:
E       StringState.STATE_TRANSLATED
E       10
E       
E       + [10, 30, 20]
E       - [StringState.STATE_TRANSLATED,
E       -  StringState.STATE_FUZZY,
E       -  StringState.STATE_APPROVED]

.../trans/tests/test_models.py:1652: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@nijel
nijel disabled auto-merge October 25, 2026 17:52
@nijel
nijel merged commit 49d66ad into main Oct 25, 2026
44 of 46 checks passed
@nijel
nijel deleted the worflow-work branch October 25, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant