Repository navigation
feat(dev): add isolated worktree devcontainers - #21480
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nijel
commented
Sep 5, 2026
Provide reproducible test and lint environments with per-checkout PostgreSQL, Valkey, storage, and Git worktree mounts. Add bootstrap, diagnostics, lifecycle commands, and CI smoke coverage to make local verification repeatable. Reject dotenv project-name overrides to keep startup and cleanup isolated. Switch the existing development stack to Valkey with a fresh data volume. Fixes WeblateOrg#13488
nijel
enabled auto-merge (rebase)
September 5, 2026 08:36
Run rundev tests through the isolated devcontainer environment using Compose, without requiring the Dev Container CLI. Share Valkey configuration and consolidate development container checks into one ARM workflow. Extend Renovate file matching so split Compose definitions retain image tag and digest updates.
Share application and test lifecycle handling between rundev and devcontainer. Give application QA separate storage and networks with dynamically allocated loopback URLs, allowing concurrent worktrees without port conflicts. Consolidate shared Compose definitions and use Renovate's default file matching. Add profile-scoped cleanup, domain activation, and concurrent ARM smoke coverage. Keep IDE shutdown project-wide while launcher stop commands affect only their selected profile.
Compose up --wait fails because the developer container disables the application's HTTP healthcheck. Rely on the existing healthy service dependencies and bootstrap checks instead, and cover the startup command in host tests.
nijel
disabled auto-merge
September 5, 2026 09:07
The base image installs Python through uv in a version- and architecture-specific directory. Expose that interpreter on PATH before virtualenv bootstrap and activate the application with /usr/bin/env python3 instead of a nonexistent fixed path. Exercise domain-file creation and replacement in the regression test.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59f2dd0f7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Discover the managed Python interpreter without populating the runtime uv cache as root, preventing permission failures during container bootstrap. Define application build and environment-file paths in the base Compose file and verify their resolved locations with a Compose configuration test.
Install native Chromium and its matching driver without APT version pins. Share Selenium setup with browser diagnostics and expose mandatory browser tests through both development launchers, with ARM and amd64 CI coverage.
Check values loaded from the application environment file instead of env_file metadata, which is omitted by the Compose version used in CI.
Exercise real Celery delivery, transaction retries, repository commits, exports, rendered statistics, translation memory, and Maildev notifications. Share the application-test command between launchers and run the journeys in CI with bounded waits and worker diagnostics.
Application startup prunes the uv cache, removing the smoke test marker. Verify persistence in application data, virtual environment, and home volumes instead.
nijel
enabled auto-merge (rebase)
September 6, 2026 06:40
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52a9552cb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Recreate persisted virtual environments when the image Python changes or the interpreter is broken. Preserve profile filters for option-only log requests and require successful HTTP health checks before application QA starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide reproducible test and lint environments with per-checkout PostgreSQL, Valkey, storage, and Git worktree mounts. Add bootstrap, diagnostics, lifecycle commands, and CI smoke coverage to make local verification repeatable.
Reject dotenv project-name overrides to keep startup and cleanup isolated. Switch the existing development stack to Valkey with a fresh data volume.
Fixes #13488