Skip to content

to master#206

Merged
JoshuaVSherman merged 7 commits intomasterfrom
dev
May 1, 2026
Merged

to master#206
JoshuaVSherman merged 7 commits intomasterfrom
dev

Conversation

@JoshuaVSherman
Copy link
Copy Markdown
Contributor

No description provided.

JoshuaVSherman and others added 7 commits April 30, 2026 19:14
- src/AgController/index.ts: drop superagent import + field; call backend
  user lookup via Node 24 fetch with Accept/Authorization headers; check
  res.ok and parse JSON. user.body.userType -> user.userType.
- test/AgController/index.spec.ts: stub global fetch via vi.stubGlobal
  (with afterEach unstubAllGlobals) instead of patching agController
  .superagent.get chained .set().set() in three newTour tests.
- src/lib/routeUtils.ts: express 5 / path-to-regexp 8 dropped bare '*';
  catch-all SPA route is now '/*splat'.
- package.json: bump @types/express ^4 -> ^5 to match express ^5.2.1.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- vitest 3.2.4 -> 4.1.5, @vitest/coverage-v8 3.2.4 -> 4.1.5
- vitest.config.ts: pool 'forks' kept, but poolOptions.forks moved to
  top-level 'forks' (vitest 4 flattened poolOptions; old key emits a
  deprecation warning).

All 66 tests pass. The 3 moderate npm-audit vulns still chain through
socketcluster-client -> uuid; they will resolve in P2 once
socketcluster-server is aligned to 20.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CLI / utility deps:
- cross-env 7 -> 10
- supports-color 9 -> 10
- serve-static 1 -> 2

SocketCluster ecosystem (aligning server with already-bumped client@20):
- socketcluster-server 17 -> 20
- @types/socketcluster-server 17 -> 20
- eetase 5 -> 7
- consumable-stream 2 -> 3
- sc-errors 2 -> 3

Verified: 66 unit tests pass, prod smoke (test:prod) passes (server up
5s on port 8888). Skipped @types/node 25 since engine pins Node 24.

Known: 3 moderate npm-audit vulns persist via socketcluster-client@20
-> uuid@8.3.2. socketcluster-client@20 is the latest release; no
upstream version pulls uuid >=14, so this is not actionable from our
side (the audit's recommended downgrade to client@9 would be a
regression).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
more upgrades: fetch migration, vitest 4, socketcluster v20
Captures the design discussed but not implemented: stack startup via
mongodb-memory-server + spawned web-jam-back/cluster children, JWT
injection auth (skipping Google OAuth), one happy-path test, plus
local + CircleCI run targets.

Not implementing now — parked for future prioritization.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@JoshuaVSherman JoshuaVSherman merged commit a9f34b9 into master May 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant