Skip to content

emmalloc: use __heap_end instead of sbrk(0)#462

Merged
sunfishcode merged 1 commit into
WebAssembly:mainfrom
cuviper:emmalloc-heap-end
Jan 10, 2024
Merged

emmalloc: use __heap_end instead of sbrk(0)#462
sunfishcode merged 1 commit into
WebAssembly:mainfrom
cuviper:emmalloc-heap-end

Conversation

@cuviper

@cuviper cuviper commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

This synchronizes emmalloc with the dlmalloc changes in #377 and #394.

@cuviper

cuviper commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

This is an alternative to #378, and more current since __heap_end was made mandatory in #394. I had suggested changes in that other PR a few months ago, but never heard back.

@sunfishcode sunfishcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit 03b228e into WebAssembly:main Jan 10, 2024
toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants