Repository navigation
Conversation
Previously, `Array2Struct` constructed `structNew` and `arrayNewReplacement` in its constructor before walking the function body. This captured the allocation's `init` or `values` children prior to the post-order walk. However, when an `array.new` or `array.new_fixed` inside an unreachable loop read from itself (via the loop backedge) inside its own initializer operands, `Array2Struct` replaced those inner uses during the walk while `arrayNewReplacement` retained stale pointers to the unreplaced `array.get` expressions. Fix this by constructing `structNew` and `arrayNewReplacement` inside `visitArrayNew` and `visitArrayNewFixed` after child operands have been visited. Also keep `structNew->type` as the concrete struct reference type even when an operand becomes `unreachable`, and defer `ReFinalize` until the end of `Struct2Local` so unreachability inside an operand does not propagate to `structNew->type` before `Struct2Local` runs. `StructNew` does not store its heap type separately from `type`, so `Struct2Local` depends on `structNew->type` remaining a concrete struct reference to look up the struct's fields when allocating locals and to construct the replacement `ref.null`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Array2StructconstructedstructNewandarrayNewReplacementin its constructor before walking the function body. This captured the allocation'sinitorvalueschildren prior to the post-order walk. However, when anarray.neworarray.new_fixedinside an unreachable loop read from itself (via the loop backedge) inside its own initializer operands,Array2Structreplaced those inner uses during the walk whilearrayNewReplacementretained stale pointers to the unreplacedarray.getexpressions. Fix this by constructingstructNewandarrayNewReplacementinsidevisitArrayNewandvisitArrayNewFixedafter child operands have been visited.Also keep
structNew->typeas the concrete struct reference type even when an operand becomesunreachable, and deferReFinalizeuntil the end ofStruct2Localso unreachability inside an operand does not propagate tostructNew->typebeforeStruct2Localruns.StructNewdoes not store its heap type separately fromtype, soStruct2Localdepends onstructNew->typeremaining a concrete struct reference to look up the struct's fields when allocating locals and to construct the replacementref.null.