[Rodri5449]

update_lit_checks.py expanded %s/%S/%t before parsing foreach and
didn't quote them for the shell, so paths with spaces broke the updater.
This parses foreach first and quotes expanded paths.

Added test/unit/test_update_lit_checks_paths.py (real updater + wasm-opt
in a directory with spaces): 4 of 5 variants fail before the fix, all pass
after. Tested on Ubuntu (WSL) only.

[gemini-code-assist]

Code Review

This pull request updates scripts/update_lit_checks.py to properly handle and escape paths containing spaces (such as %s, %S, and %t) when executing shell commands, using platform-appropriate quoting (shlex.quote or subprocess.list2cmdline). It also updates the foreach parsing logic to support arguments with spaces and introduces a new unit test suite in test/unit/test_update_lit_checks_paths.py to verify these changes across various scenarios. There are no review comments, and I have no additional feedback to provide.

[tlively]

Do we have lit tests with spaces where this matters? If not, it might be better to just add a TODO comment and save the complexity of making this more robust for now.