Repository navigation
Migrate three legacy pass tests to lit - #9367
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new LIT-style tests for several WebAssembly optimization passes in wasm-opt, specifically targeting duplicate import elimination, the interaction between unused name removal and precomputation, and setting globals via pass arguments. These tests replace older, separate test files to streamline the test suite. I have no feedback to provide as there are no review comments and the changes consist of clean test additions.
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM besides the one comment.
| @@ -0,0 +1,42 @@ | |||
| ;; RUN: foreach %s %t wasm-opt --duplicate-import-elimination -S -o - | filecheck %s | |||
There was a problem hiding this comment.
Please use scripts/update_lit_checks.py --all-items to generate the test output for this file as well..
There was a problem hiding this comment.
Done! I regenerated the checks with "--all-items" and reran the three migrated tests. All three passed. Thanks for the review :))
|
Thanks for the PR! |
Migrate three legacy pass tests to lit:
Each test now includes its RUN command and FileCheck expectations.
Remove the corresponding legacy input/output files and preserve the
set-globals pass arguments (foo=1337,bar=42).
No optimization pass implementations are changed!
Validation:
Related to #8520.