Skip to content

Fix removal of team review request #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
Nov 7, 2026
Merged

Fix removal of team review request #9360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions scripts/assign_reviewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,20 +310,15 @@ def main() -> None:
if n['requestedReviewer']
)
if team_requested:
try:
gh_api([
'--method',
'DELETE',
f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers',
'-f',
f'team_reviewers[]={TEAM_SLUG}',
])
except subprocess.CalledProcessError as e:
detail = e.stderr.strip() if e.stderr else str(e)
print(
f'Note: could not remove team review request: {detail}',
file=sys.stderr,
)
gh_api([
'--method',
'DELETE',
f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers',
'-f',
'reviewers[]',
'-f',
f'team_reviewers[]={TEAM_SLUG}',
])
Comment on lines +313 to +321

@gemini-code-assist gemini-code-assist Bot Nov 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the try...except block makes the script fragile. If the DELETE request to remove the team review request fails (for example, due to transient GitHub API issues or permission limitations), the entire script will crash with an unhandled subprocess.CalledProcessError. Since the primary action of assigning the individual reviewer has already succeeded, this cleanup step should fail gracefully rather than crashing the script.

Suggested change
gh_api([
'--method',
'DELETE',
f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers',
'-f',
'reviewers[]',
'-f',
f'team_reviewers[]={TEAM_SLUG}',
])
try:
gh_api([
'--method',
'DELETE',
f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers',
'-f',
'reviewers[]',
'-f',
f'team_reviewers[]={TEAM_SLUG}',
])
except subprocess.CalledProcessError as e:
detail = e.stderr.strip() if e.stderr else str(e)
print(
f'Note: could not remove team review request: {detail}',
file=sys.stderr,
)

@tlively tlively Nov 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather hear loudly about failures, even after the main action has been completed successfully.



if __name__ == '__main__':
Expand Down
Loading