Repository navigation
Bridge: sync setup and vhlabvisspike2 to NDI-matlab 3c80bc32b (#1114) - #352
Merged
Merged
Conversation
VH-Lab/NDI-matlab#1114 merged into main as 3c80bc32b. Its only change to vhlabvisspike2.m is the stimulus-mismatch error message that #351 already ported, so the vhlabvisspike2 entry moves its sync hash there and drops the "not yet merged" wording. Every other change #1114 makes under +ndi/+setup is in +ndi/+setup/+conv/+vhlab (the Stacy legacy-data importer), which has no Python port; the root bridge's setup entry records that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011v7R5uJJtaq8SVB4eEwnBR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #351 now that VH-Lab/NDI-matlab#1114 has merged into NDI-matlab main as
3c80bc32b. The change is bridge-only.vhlabvisspike2(src/ndi/setup/daq/reader/mfdaq/stimulus/ndi_matlab_python_bridge.yaml): the sync hash moves fromfe64a9f53to3c80bc32b. #1114's only change tovhlabvisspike2.mis the stimulus-mismatch error message, which vhlabvisspike2: decode stimulus events from stimtimes.txt and stims.mat #351 already ported, so no code changes. The "not yet merged" wording is gone.setup(rootsrc/ndi/ndi_matlab_python_bridge.yaml): adds a "Re-examined against NDI-matlab 3c80bc32b" note and moves the sync hash to3c80bc32b. Every other change #1114 makes under+ndi/+setup/is in+ndi/+setup/+conv/+vhlab(importMeasuredDataCells, the newmatchCellIntervalsToEpochsandparseCellName, andvalidateStacyDirectory). That importer has no Python port.Without this change, the bridge drift check would flag
vhlabvisspike2now that #1114 is on main.black --check,ruff checkand the fullpytest tests/pass. The bridge tests (204) also pass against NDI-matlab main at3c80bc32bwith full history.Generated by Claude Code