Repository navigation
Governance quorum, upgrade timelock, storage versioning, and legacy-tree PR migration - #997
Merged
Merged
Conversation
…istration Closes WHEELBACK#952
|
@emdy9008 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governance quorum, upgrade timelock, storage versioning, and legacy-tree PR migration
What was solved
#951 — Migrate open PRs targeting legacy trees
This issue is a repository-maintenance/process task: audit open pull requests that still modify the legacy trees contracts/, backend/, or frontend/, and migrate their changes onto the canonical paths before those legacy trees are deleted. The acceptance criterion is that no open PR targets a tree scheduled for removal. It is not a code change to application logic; the deliverable is a migration/audit of open PRs plus any repo-level guidance (e.g., PR template or contributor docs) that steers new work away from legacy paths.
Addressed:
#952 — Require signer quorum for sensitive treasury administration
Add an on-chain governance flow to the treasury contract so that sensitive signer and threshold changes require a signer quorum rather than a single admin, with contract tests proving insufficient quorum cannot alter signer authority or threshold.
Addressed:
#953 — Add a timelock and cancellation flow for contract upgrades
Add a governance-controlled upgrade timelock to the treasury contract: authorized governance can schedule an upgrade (recording a review window), the delay must elapse before execution, and governance can cancel a pending upgrade. Tests cover scheduling, delay enforcement, cancellation, and execution.
Addressed:
#954 — Version contract storage schemas and test migrations
Add explicit storage schema versioning to the Soroban contracts (treasury, invoice, compliance) with migration logic and tests that validate supported migrations plus safe handling of unknown or malformed versions.
Addressed:
Changes
.github/CODEOWNERS(modify)COMEBACKHERE-contracts/contracts/treasury/src/integration_settlement_multisig.rs(modify)CONTRIBUTING.md(modify)COMEBACKHERE-contracts/contracts/treasury/src/events.rs(modify).github/pull_request_template.md(modify)README.md(modify)Approach
Issues
Closes #951
Closes #952
Closes #953
Closes #954