Skip to content

Test/comebackhere 903 904 - #1003

Merged
levoski1 merged 2 commits into
WHEELBACK:mainfrom
MusaTheDev001:test/comebackhere-903-904
Oct 21, 2026
Merged

levoski1 merged 2 commits into
WHEELBACK:mainfrom
MusaTheDev001:test/comebackhere-903-904

Conversation

@MusaTheDev001

Copy link
Copy Markdown
Contributor

Summary

  • backend/src/soroban.rs: get_invoice's simulateTransaction call only checked the top-level JSON-RPC error field; a simulation-level failure (e.g. an expired ledger footprint) instead lands in result.error and was silently swallowed into an all-defaulted InvoiceResponse. Now checks result.error and returns it directly.
  • COMEBACKHERE-contracts/contracts/treasury/src/lib.rs: withdraw's destination parameter was named _to and never used — the function tracked the daily-limit bookkeeping but never actually transferred funds out. Renamed to to and added the missing token::Client::transfer call.

Closes #903
Closes #904

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@MusaTheDev001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@levoski1
levoski1 merged commit 4b10823 into WHEELBACK:main Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants