Skip to content

fix: add support for startupinfo - #181

Merged
Vizonex merged 6 commits into
Vizonex:mainfrom
winstxnhdw:main
Oct 24, 2026
Merged

Vizonex merged 6 commits into
Vizonex:mainfrom
winstxnhdw:main

Conversation

@winstxnhdw

Copy link
Copy Markdown
Contributor

What do these changes do?

Support Playwright’s Windows startupinfo settings so its driver can start without raising an error.

Are there changes in behavior for the user?

None. Playwright should now work.

Is it a substantial burden for the maintainers to support this?

None. There should be no need to touch this in the future unless the Windows API somehow changes drastically.

Related issue number

Fixes #34

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Comment thread winloop/handles/process.pyx

@Vizonex Vizonex left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one thing to add before this PR continues and that isn't having to do with bugs but rather an explanation (Small Comment nothing big). This is because winloop & uvloop plan to be merged in a future update and then winloop will no longer be needed (decommissioned at my own wish). I always leave little notes behind about changes here for that reason as it gives the magicstack triage an explanation about why this is needed in windows and etc. This also gives users something to look up if there are any further questions about a particular code change.

Comment thread winloop/handles/process.pyx Outdated
@Vizonex

Vizonex commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

@winstxnhdw I'll fix it up for you since you gave me edit privileges.

@Vizonex

Vizonex commented Oct 24, 2026

Copy link
Copy Markdown
Owner

@winstxnhdw Ignore the failing check for 3.11 it's an old rounding bug that has yet to be solved. It's an on/off bug that has always been random.

Comment thread winloop/handles/process.pyx Outdated

@Vizonex Vizonex left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing before I let you go. We need to be sure to leave a comment about why this is changed.

@Vizonex
Vizonex self-requested a review October 24, 2026 21:53

@Vizonex Vizonex left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly tweaked your code a bit now I can approve this PR.

@Vizonex
Vizonex merged commit 5888e73 into Vizonex:main Oct 24, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winloop + Playwright -> startupinfo is not supported

2 participants