Repository navigation
fix: add support for startupinfo - #181
Conversation
Vizonex
left a comment
There was a problem hiding this comment.
I just have one thing to add before this PR continues and that isn't having to do with bugs but rather an explanation (Small Comment nothing big). This is because winloop & uvloop plan to be merged in a future update and then winloop will no longer be needed (decommissioned at my own wish). I always leave little notes behind about changes here for that reason as it gives the magicstack triage an explanation about why this is needed in windows and etc. This also gives users something to look up if there are any further questions about a particular code change.
|
@winstxnhdw I'll fix it up for you since you gave me edit privileges. |
|
@winstxnhdw Ignore the failing check for 3.11 it's an old rounding bug that has yet to be solved. It's an on/off bug that has always been random. |
Vizonex
left a comment
There was a problem hiding this comment.
One more thing before I let you go. We need to be sure to leave a comment about why this is changed.
Vizonex
left a comment
There was a problem hiding this comment.
I mostly tweaked your code a bit now I can approve this PR.
What do these changes do?
Support Playwright’s Windows
startupinfosettings so its driver can start without raising an error.Are there changes in behavior for the user?
None. Playwright should now work.
Is it a substantial burden for the maintainers to support this?
None. There should be no need to touch this in the future unless the Windows API somehow changes drastically.
Related issue number
Fixes #34
Checklist