Skip to content

place temporary 3.14t bandage until ctypedef callback can be applied. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vizonex merged 1 commit into from
Oct 1, 2026
Merged

place temporary 3.14t bandage until ctypedef callback can be applied. #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions winloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ cdef class Loop:
# Let's Convert this callback to a ctypedef callback
# for added performance.
# example: ctypedef int (*addrinfo_callback)(Future fut, object result) except -1
def callback(result):
def callback(fut, result):
if AddrInfo.isinstance(result):
try:
if unpack == 0:
Expand All @@ -939,7 +939,9 @@ cdef class Loop:
if not fut.cancelled():
fut.set_exception(result)

AddrInfoRequest(self, host, port, family, type, proto, flags, callback)
# NOTE: ft_partial is needed to hold future for long enough
# otherwise 3.14t could freeze.
AddrInfoRequest(self, host, port, family, type, proto, flags, ft_partial(callback, fut))
return fut

cdef Future _getnameinfo(self, system.sockaddr *addr, int flags):
Expand All @@ -950,13 +952,13 @@ cdef class Loop:
# Ditto of 0.8.0's TODO list:
# Something like ctypedef int (*nameinfo_callback)(Future, object) except -1
# would be sufficient.
def callback(result):
def callback(fut, result):
if isinstance(result, tuple):
fut.set_result(result)
else:
fut.set_exception(result)

nr = NameInfoRequest(self, callback)
nr = NameInfoRequest(self, ft_partial(callback, fut))
nr.query(addr, flags)
return fut

Expand Down
Loading