Skip to content

Fix bidirectional#97

Merged
tonywu1999 merged 2 commits intodevelfrom
fix-bidirectional
Apr 16, 2026
Merged

Fix bidirectional#97
tonywu1999 merged 2 commits intodevelfrom
fix-bidirectional

Conversation

@tonywu1999
Copy link
Copy Markdown
Contributor

@tonywu1999 tonywu1999 commented Apr 16, 2026

Motivation and Context

Bidirectional edges were causing practical problems w.r.t. edge deletion and link clicking. Removing them now.

Changes

  • Remove references to bidirectional edges
  • Simplify code
  • Remove dead code

Testing

Fixed unit tests

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • Ran styler::style_pkg(transformers = styler::tidyverse_style(indent_by = 4))
  • Ran devtools::document()

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@tonywu1999 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8e9e0519-3055-4722-bc1d-67d738a585cb

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8dadd and 16d7ae0.

📒 Files selected for processing (4)
  • R/cytoscapeNetwork.R
  • R/utils_cytoscapeNetwork.R
  • inst/htmlwidgets/cytoscapeNetwork.js
  • tests/testthat/test-utils_cytoscapeNetwork.R
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-bidirectional

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.70%. Comparing base (3a8dadd) to head (16d7ae0).

Files with missing lines Patch % Lines
R/utils_cytoscapeNetwork.R 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #97      +/-   ##
==========================================
- Coverage   76.79%   76.70%   -0.10%     
==========================================
  Files           8        8              
  Lines        1030     1026       -4     
==========================================
- Hits          791      787       -4     
  Misses        239      239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonywu1999 tonywu1999 merged commit 8991901 into devel Apr 16, 2026
4 checks passed
@tonywu1999 tonywu1999 deleted the fix-bidirectional branch April 16, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants