fix: prevent oversized liquid values from hiding wave - #4576
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
skie1997
approved these changes
May 12, 2026
Clamp liquid geometry ratios above 1 to a full-water state while keeping data intact. Also add local browser controls for checking the chart across container sizes. Constraint: Oversized user values must not move the wave outside the visible mask. Scope-risk: narrow Confidence: high Tested: npm test -- __tests__/unit/series/liquid.test.ts
xile611
force-pushed
the
fix/fix-liquid-whit-big-value
branch
from
September 15, 2026 08:23
bcee007 to
ae83dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp liquid geometry ratios above 1 to a full-water state while keeping data intact.
Also add local browser controls for checking the chart across container sizes.
Constraint: Oversized user values must not move the wave outside the visible mask.
Scope-risk: narrow
Confidence: high
Tested: npm test -- tests/unit/series/liquid.test.ts
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough