fix: bar smapling not work bug. fix#4571 - #4573
Conversation
|
🦞 Aime Bot Review 改动摘要:本 PR 针对 bar 系列在开启 sampling 时不生效的问题,将数据变换流水线中的 transform 类型从 代码层面的具体观察:在 小提示:PR 标题以及 changelog 中的文案里 合并建议:整体改动范围很小、意图明确,且有针对性的单测覆盖。如果已经在本地验证过其他典型场景(例如不同方向或不同 |
🦞Aime Bot Review Summary of changes: This PR aims at the problem that the bar series does not take effect when sampling is turned on. The transform type in the data transformation pipeline is adjusted from Specific observations at the code level: In Tip: It is recommended to change Merger suggestion: The overall scope of changes is small, the intention is clear, and targeted single test coverage. If other typical scenarios have been verified locally (such as different directions or different |
|
@codex review |
xile611
left a comment
There was a problem hiding this comment.
@skie1997 感谢修复!将 sampling 改为已注册的 dataSampling,能够解决开启采样后柱图不显示的问题,业务修复方向是正确的。
合并前麻烦处理以下两点:
- 修复新增测试的初始化方式,详见行内评论。将此提交应用到当前 develop(
5d03e35856d093a2d6b0b4cd5bcf0a4a5dd7f9d8)后,运行柱图测试可复现释放阶段的TypeError: this._compiler.removeEventListener is not a function。建议复用该文件已有的createBarChart(samplingSpec)。 - 在 PR 描述中补充 BugServer case ID,并在同步 develop 后重跑失败的检查。PR 检查 明确提示:
Can't find case id of bugserver in the pull request body;Bug Server CI 和 size 检查也仍处于失败状态,需要确认重跑结果。
我在临时副本中改用现有测试工厂后,柱图测试共 14 项通过,其中包含额外补充的 6 项大数据量采样验证,覆盖纵向、横向、分组及 samplingFactor。麻烦修复上述测试问题并确认 CI 通过后再合并,谢谢!
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #4571
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough