Fix x2go client path lookup in direct.py script#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important fix to the way the
findAppfunction is called in thedirect.pyscript for the X2GO Windows transport. The change ensures that the search path for thex2goclient.exeexecutable is passed correctly, which could affect the ability to locate the required application. The code signature file was also updated to reflect this change.Bug Fix:
findAppfunction indirect.pyby passingx2goPathas a string instead of a list, ensuring the executable is searched for in the intended directory.Maintenance:
.signaturefile fordirect.pyto match the new code state.