Closed
Conversation
Enables PKCS7-based signing of RDP files using configured certificates and key chain. Orders and filters RDP settings for signature scope according to Microsoft requirements, improving compatibility with mstsc.exe. Passes and stores a signing ticket to the relevant scripts and templates, enhancing traceability and session control. Adds detailed logging for easier troubleshooting and auditing of the RDP signing process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for cryptographically signing RDP files on the server side, ensuring enhanced security and authenticity for RDP connections. The main changes add the ability to generate and append signatures to RDP files, expose a REST API endpoint for signing RDP content, and update the RDP transport scripts to utilize this new functionality. Additionally, the cryptographic code has been refactored for better organization.
RDP File Signing Functionality:
rdp.py, underserver/src/uds/core/managers/crypto/that implements RDP file signing using PKCS7 signatures, loading certificates and keys from configurable paths. The signing process appends signature and signscope lines to RDP files.crypto.pyinto the newcrypto/rdp.pymodule, and exposed asign_rdpmethod on theCryptoManagerfor signing RDP data. [1] [2]REST API and Backend Integration:
rdp_signatureto the client endpoint, which signs provided RDP content using the server's certificate and returns the signed result. [1] [2] [3]RDP Transport and Ticketing:
rdp.py,rdptunnel.py) to generate a short-lived ticket for each RDP signing operation, passing this ticket to the signing process for validation and traceability. [1] [2] [3]Windows RDP Script Updates:
Submodule Update:
clientsubmodule to a new commit, likely to support or consume the new RDP signing features.