Skip to content

feat: handles manual transaction approval#12

Open
andrew-virtuals wants to merge 4 commits into
mainfrom
feat/policy-guardrail
Open

feat: handles manual transaction approval#12
andrew-virtuals wants to merge 4 commits into
mainfrom
feat/policy-guardrail

Conversation

@andrew-virtuals
Copy link
Copy Markdown
Contributor

@andrew-virtuals andrew-virtuals commented May 12, 2026

Note

High Risk
High risk because it changes authentication signing from message-signing to EIP-712 typed data and modifies the Privy/Alchemy transaction submission path to support manual approval and new user-operation signing, impacting wallet security and transaction execution flow.

Overview
Switches agent/provider authentication from signMessage to EIP-712 typed-data signatures via new core/agentAuth.ts and updates all auth clients/context to send issuedAt + typed data instead of a raw message.

Adds a manual approval gate (core/approvalGate.ts) and a new SSE wallet stream alongside chat; SseTransport.connect() and AcpAgent.start() now accept configurable SupportedStreams (defaulting to chat+wallet) and the wallet stream resolves pending approvals.

Updates PrivyAlchemyEvmProviderAdapter to detect server-side APPROVAL_REQUIRED responses, wait for approval events before continuing, and changes call submission to a prepare/sign-user-operation/send-prepared flow using a configured ALCHEMY_SIGNING_CONTRACT.

Reviewed by Cursor Bugbot for commit 1ec514b. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/providers/evm/privyAlchemyEvmProviderAdapter.ts
Comment thread src/providers/evm/privyAlchemyEvmProviderAdapter.ts
Comment thread src/providers/evm/privyAlchemyEvmProviderAdapter.ts
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 559f5a9. Configure here.

Comment thread src/events/sseTransport.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants