Repository navigation
Report rejected feature-control downloads and unreadable tunes under their own diagnostic classes - #158
Merged
Conversation
…their own diagnostic classes
A feature-control download Wisp rejected or could not keep was reported without an incident,
so the collector's placeholder reached Tools as "Failure report is missing its diagnostic
classification" and, on 2026-10-22 when the service let an envelope expire, as an app-wide bug
across five PCs. The report now carries its own category (feature-control: policy-rejected,
policy-cache-unavailable; stage feature-control-refresh), still once per change.
A current tune whose data could not be read was reported with reason "validation", which Tools
groups with clip export checks ("Export validation failed"); it is a tune read failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FeatureControlClient.ReportAcceptance: a download this PC rejected or could not keep now carries its own incident (feature-control/policy-rejectedorpolicy-cache-unavailable, stagefeature-control-refresh, with the usual health context), still once per change. Before, it was recorded without an incident, soSupplementaryObservations.EnsureClassificationsubstituted the collector placeholderclassification-missing.SupplementaryIncidentSchema: the matching catalog entries (category, reasons, stage).TuneCaptureService: anInvalidDataExceptionfrom the tune read is reported astune-read-failedinstead ofvalidation; Tools groupsvalidationwith clip export checks, so these showed as "Export validation failed".FeatureControlTests.RejectedDownloadIsReportedOnceWithItsOwnIncident(expired envelope → one failure observation with the new incident, schema-valid),NativeTuneCaptureTests.TuneDataThatCannotBeReadIsAReadFailureNotAnExportCheck.FeatureControlTestsjoins the "Supplementary instrumentation" collection because the new test swaps the process-wide observer.Why
2026-10-22 14:23:42Z: feature-control revision 2 expired on the service; the five 2.7.0 PCs online at that instant rejected it and reported the placeholder, which Tools raised as "Failure report is missing its diagnostic classification" and then "Wisp is crashing or failing on more PCs than usual". The service side is fixed (Views2k/wisp-site#352); this makes the client's report self-describing.
Order
Tools must accept the new wire values before a release that sends them: merge and deploy Views2k/wisp-site#354 first (Tools returns 400
invalid_incidentfor an unknown category and the app drops the batch).Checks
dotnet format whitespace --verify-no-changeson the changed files.