Skip to content

fix(dart_pub_publish): requires pub_credentials secret despite using OIDC #540

Closed

Description

@marcossevilla

Description

dart_pub_publish.yml declares pub_credentials as a required secret:

secrets:
  pub_credentials:
    required: true

However, the workflow is documented as using automated publishing via OIDC, the inline comment marks the secret as deprecated, and the step that consumes it is already guarded:

- name: 🔐 Setup Pub Credentials
  if: ${{ secrets.pub_credentials != '' }}

Because the secret is required: true, callers following the documented example (no secrets: block) fail workflow validation, so OIDC-only publishing isn't possible without passing a dummy secret.

Affects v2 (v2.0.3) and main.

Steps to reproduce

jobs:
  publish:
    permissions:
      id-token: write
    uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_pub_publish.yml@v2
    with:
      working_directory: packages/my_package

Expected behavior

The workflow runs and publishes using the OIDC token provisioned by dart-lang/setup-dart.

Proposed fix

     secrets:
       pub_credentials:
-        required: true
+        required: false

Optionally, also expose an environment input (forwarded to the job's environment: so callers can use GitHub deployment environments as recommended by dart.dev.

Activity

  1. changed the title [-]fix: dart_pub_publish requires pub_credentials secret despite using OIDC[/-] [+]fix(dart_pub_publish): requires pub_credentials secret despite using OIDC[/+] on Oct 28, 2026
  2. unicoderbot commented on Oct 28, 2026

    @unicoderbot
    Contributor

    Great, I will work on a PR and push it soon.

    • Preparing environment
      • Cloning repository
      • Setting up dev environment
    • Working on changes
    • Reviewing changes
    • Opening pull request

    I've opened a pull request: #541

  3. moved this from Needs Triage to In Progress in VGV Open Source 🦄 🧙🌟on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions