Repository navigation
Take the kernel from PlatformHeads.Core - #959
Merged
Merged
Conversation
SessionHost, ScreenCache, the window contract, WindowPlacement and NativeResolver were written here and copied into BuildMonitor, and the copies drifted: each held fixes the other lacked. PlatformHeads 0.2.0 has one copy of them, made from both, which BuildMonitor took in SimonCropp/BuildMonitor#53, and this takes it: - SessionHost.cs, ScreenCache.cs, WindowPlacement.cs and NativeResolver.cs go. Directory.Build.props names SessionHost, ScreenCache and OpenWindow for the viewer's state, screen and window, and DiffEngineViewer.Benchmarks.csproj again, since it imports nothing above it. - IViewerWindow derives from IHeadWindow. Deview.Resolve registers the library by name. - SessionHost now throws when a mutation mutates again, which silently undid the outer one. Nothing here does: the whole suite passes. And one fix that comes with it. Copying handed the text to the window from inside the mutation, and the WinForms head swallowed the refusal of a clipboard another process held, so the copy was lost while the status line said it had been made. A copy now waits in SessionState.Clipboard, and the loop offers it through the kernel's ClipboardPump for a few frames, then says it could not copy. SetClipboard answers whether it took the text; the native heads always do. The packages carry PlatformHeads.Core.dll beside each head, which is the one change to the entries Packaging.Tests has on record. All four pins move to 0.2.0 together; nothing in the build package, the CMake module or the workflow changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewer's managed plumbing was written here and copied into BuildMonitor, and the copies drifted. PlatformHeads 0.2.0 has one copy as
PlatformHeads.Core, made from both, which BuildMonitor took in SimonCropp/BuildMonitor#53. This is layer 2, after the build and packaging in #954.What changes
SessionHost,ScreenCache,WindowPlacementandNativeResolvergo.Directory.Build.propsnames the genericSessionHost,ScreenCacheandOpenWindowfor the viewer's state, screen and window, andDiffEngineViewer.Benchmarks.csprojdoes again, since it imports nothing above it.IViewerWindowderives fromIHeadWindow.Deview.Resolveregisters the library by name.SessionHost.Mutatenow throws when a mutation mutates again, which silently undid the outer one. Nothing here does: the whole suite passes.uses:,GIT_TAG,PlatformHeadsand the newPlatformHeads.Core. Nothing in the build package, the CMake module or the workflow changed.One fix that comes with it
Copying handed the text to the window from inside the mutation, and the WinForms head swallowed the refusal of a clipboard another process held, so the copy was lost while the status line said it had been made. A copy now waits in
SessionState.Clipboard, and the loop offers it through the kernel'sClipboardPumpfor a few frames, then says "Could not copy …: another program is holding the clipboard."SetClipboardanswers whether it took the text; the native heads always do.ClipboardCopyTestscovers it, and the copy tests read the copy from the state rather than from the window.Checked
Packaging.Tests20/20. The one change on record isPlatformHeads.Core.dllbeside each head: six in the bundled viewer, two in the tray, one in each tool package.