Repository navigation
Explicit tests launching the viewer on every file type it compares - #917
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit tests that launch the viewer built from this working tree on a pair of every file type it compares other than text, so a person can check what each head actually draws. No product code changes.
What it adds
FileTypeLaunchTests: 21 explicit cases, one per extension..png,.bmp,.gif,.ico,.jpg,.jpeg,.webp..docx,.xlsxand.pptx..geojson,.topojson,.kml,.gpx,.wkt,.kmz,.wkb,.fgband.geoparquet.What each case does:
DiffRunner.LaunchAsync, the path a test run takes, and waits for the window to close.SampleImagesbuilds the images.SamplePngis.Other samples:
FileTypeSampleTestsis an ordinary test (18 cases) that checks every generated sample on every run:The launch tests are explicit, so without this a broken sample would only show up as an empty window.
Notes
GroupedQueuedoes. Otherwise a running DiffEngineTray takes each pair into its own queue and shows it in its installed viewer.MaxInstancesToLaunch, which is 5 by default and would refuse every launch after the fifth.Run the class like this. Each window opens after the last one is closed:
Tests