Skip to content

Serialise the tests that probe a released port, so their unowned record cannot land on another test's owner #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Sep 23, 2026
Merged

Serialise the tests that probe a released port, so their unowned record cannot land on another test's owner #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/DiffEngine.Tests/ViewerProtocolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,9 @@ await Assert.That(await ViewerClient.SendAsync(new(ViewerVerb.List), default, se
}

[Test]
// Serialised: the port it releases and probes is recorded as unowned process wide, and
// the OS may already have handed that number to another test's owner.
[NotInParallel]
public async Task AnAbsentOwnerReportsNoOwner()
{
ViewerServer.TryBind(0, out var server);
Expand Down Expand Up @@ -1119,6 +1122,8 @@ void Record(object? sender, UnobservedTaskExceptionEventArgs args)
}

[Test]
// Serialised for the same reason as AnAbsentOwnerReportsNoOwner.
[NotInParallel]
public async Task AnAbsentOwnerIsNotAnError()
{
ViewerServer.TryBind(0, out var server);
Expand Down
Loading