Skip to content

Migrate to pydantic v2 - #642

Closed
amrit110 wants to merge 2 commits into
mainfrom
migrate_to_pydanticv2
Closed

Migrate to pydantic v2#642
amrit110 wants to merge 2 commits into
mainfrom
migrate_to_pydanticv2

Conversation

@amrit110

Copy link
Copy Markdown
Member

PR Type ([Feature | Fix | Documentation | Test])

Update

Short Description

  • Migrate to pydanticv2 which has improved features and functionality

Tests Added

...

@amrit110 amrit110 added the update Updating dependencies label Jun 22, 2024
@amrit110 amrit110 self-assigned this Jun 22, 2024
@amrit110 amrit110 mentioned this pull request Aug 4, 2026
@amrit110

amrit110 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Closing as superseded by #769, which completes this migration properly: this PR's @model_validator(skip_on_failure=True) isn't valid pydantic v2 syntax (that parameter belongs to v1's root_validator), and it never touched report.py's .dict()/.json()/.validate() calls or the Extra/Config class pattern used throughout the model-card system. #769 migrates all of cyclops/report (and deploy/report/api) to pydantic v2 idioms with the full test suite passing.

@amrit110 amrit110 closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update Updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant