Rename noChildren to hasChildren for clarity#599
Rename noChildren to hasChildren for clarity#599gioalex07 wants to merge 4 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
The property noChildren returned true when children were present, which was semantically misleading. Renamed to hasChildren to match the actual behavior and avoid confusion for future contributors.
|
Thanks for the contribution.
Please update the PR with real‑device testing details so review can continue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
============================================
- Coverage 97.83% 97.76% -0.07%
- Complexity 975 979 +4
============================================
Files 121 121
Lines 2581 2813 +232
Branches 211 211
============================================
+ Hits 2525 2750 +225
- Misses 19 26 +7
Partials 37 37 🚀 New features to boost your workflow:
|
|
Thank you for the contribution. |
The property noChildren returned true when children were present, which was semantically misleading. Renamed to hasChildren to match the actual behavior and avoid confusion for future contributors.
Summary
WiFiDetail.noChildrentohasChildrenfor semantic clarity.noChildrenreturnedtruewhen children were present.What does this implement/fix?
WiFiDetail.ktAccessPointsAdapterGroup.kt(2 call sites)WiFiDetailTest.ktandAccessPointsAdapterGroupTest.ktDoes this close any issues?
How was this tested?