Skip to content

[k2] make init instance memory size adjustable#1610

Merged
PetrShumilov merged 8 commits intomasterfrom
pshumilov/make_init_instance_memory_size_adjustable
Apr 20, 2026
Merged

[k2] make init instance memory size adjustable#1610
PetrShumilov merged 8 commits intomasterfrom
pshumilov/make_init_instance_memory_size_adjustable

Conversation

@PetrShumilov
Copy link
Copy Markdown
Contributor

@PetrShumilov PetrShumilov commented Apr 16, 2026

Key changes:

  • Set initial instance memory size to 64Mb (instead of 128 Mb previously)
  • Set min instance extra memory size to 64Mb (instead of 1Mb previously)
  • Made initial instance memory size adjustable via initial-instance-memory-size component argument
  • Made min instance extra memory size adjustable via min-instance-extra-memory-size component argument

@PetrShumilov
Fix diagnostic in cases when memory is not enough
4c7ae0f 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Make initial instance memory size adjustable
a9a0d54 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Make min instance extra memory size adjustable
ded3d79 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov added this to the next milestone Apr 16, 2026
@PetrShumilov PetrShumilov self-assigned this Apr 16, 2026
@PetrShumilov PetrShumilov added runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode kphp Affects compiler or runtime in default mode (not K2) labels Apr 16, 2026
@PetrShumilov
Fix code style
fd44888 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch from 8e7f97c to fd44888 Compare April 16, 2026 15:46
@PetrShumilov
Refactor extra mem allocation mechanic
ebb4de1 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch 3 times, most recently from ba96544 to 021eeaa Compare April 16, 2026 15:59
@PetrShumilov
Fix code formatting
3e60f0d 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch from 021eeaa to 3e60f0d Compare April 16, 2026 16:01
@PetrShumilov
Fix test
0d42799 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch 2 times, most recently from ee87c9c to 3007a41 Compare April 17, 2026 13:54
astrophysik
astrophysik previously approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@astrophysik astrophysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apolyakov
apolyakov reviewed Apr 17, 2026
View reviewed changes
Comment thread runtime-light/allocator/allocator-state.h Outdated
Comment thread runtime-light/state/component-state.h Outdated
Comment thread runtime-light/state/component-state.cpp Outdated
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch 2 times, most recently from f9f2f56 to 6174781 Compare April 17, 2026 16:04
apolyakov
apolyakov requested changes Apr 17, 2026
View reviewed changes
Comment thread runtime-common/core/allocator/runtime-allocator.h Outdated
Comment thread runtime-common/core/allocator/runtime-allocator.h Outdated
Comment thread runtime-common/core/allocator/runtime-allocator.h Outdated
@PetrShumilov
Fix code style
a263244 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/make_init_instance_memory_size_adjustable branch from 6174781 to a263244 Compare April 17, 2026 16:19
apolyakov
apolyakov approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@apolyakov apolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PetrShumilov PetrShumilov merged commit 11d3605 into master Apr 20, 2026
7 checks passed
@PetrShumilov PetrShumilov deleted the pshumilov/make_init_instance_memory_size_adjustable branch April 20, 2026 08:07
PetrShumilov added a commit that referenced this pull request Apr 21, 2026
@PetrShumilov
Revert "[k2] make init instance memory size adjustable (#1610)" (#1614)
ccd5a17 
This reverts commit 11d3605.
@PetrShumilov PetrShumilov mentioned this pull request Apr 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolyakov apolyakov apolyakov approved these changes

@astrophysik astrophysik astrophysik left review comments

Assignees

@PetrShumilov PetrShumilov

Labels

k2 Affects compiler or runtime in K2 mode kphp Affects compiler or runtime in default mode (not K2) runtime Feature related to runtime

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

3 participants

@PetrShumilov @apolyakov @astrophysik