Skip to content

Di/fix esp32 cursor offset issue411 - #423

Open
DaniilSmirnov wants to merge 4 commits into
VKCOM:developfrom
DaniilSmirnov:di/fix-esp32-cursor-offset-issue411
Open

DaniilSmirnov wants to merge 4 commits into
VKCOM:developfrom
DaniilSmirnov:di/fix-esp32-cursor-offset-issue411

Conversation

@DaniilSmirnov

Copy link
Copy Markdown

Summary

  • Fix the misspelled Y coordinate field that prevented cursor movement from starting.
  • Keep the estimated cursor position in the same units as the ESP32 firmware’s 1, 4, and 8 step commands.
  • Correct horizontal and vertical movement directions.
  • Make diagonal movement deterministic to reduce drift in the estimated cursor position.
  • Add unit tests for movement step selection and firmware command mapping.

Validation

  • ESP32 movement tests: 13 passed.
  • ESLint on the changed JavaScript files passed.
  • Syntax checks and git diff --check passed.

Fixes #411

@DaniilSmirnov
DaniilSmirnov requested a review from a team as a code owner September 25, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant