Repository navigation
sqlitedb: _is_safe_uid delegates to did.file.is_safe_uid - #96
Merged
Merged
Conversation
The docstring of did.file.is_safe_uid said SQLiteDB's _is_safe_uid delegated to it, but it was a separate copy of the same predicate. The two bodies agreed, so behaviour is unchanged. _is_safe_uid now calls is_safe_uid, as MATLAB's sqlitedb.isSafeUid calls did.file.isSafeUid, so the check lives in one place. Both bridge entries are updated to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Dn4gCNCU2jUGdmfPVCAGK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup found while writing the bridge entries in #91.
did.file.is_safe_uidsaysSQLiteDB._is_safe_uiddelegates to it, but_is_safe_uidwas a separate copy of the same predicate. The two bodies agreed, so there was no bug yet, just two copies that could drift apart._is_safe_uidnow callsis_safe_uid, the way MATLAB'ssqlitedb.isSafeUidcallsdid.file.isSafeUid. There's no behaviour change.isSafeUidentries, the implementations one and the file one, are updated to say it delegates._is_safe_uid's behaviour, so there are no new ones.Locally:
black --check,ruff check(0.16.5),pytest(800 passed) andcheck_bridge_coverage.py(0 problems).Generated by Claude Code