Repository navigation
docs: keep an in-use SQLite database out of sync folders - #95
Merged
Merged
Conversation
#94 catches a database file replaced during a write. Sync clients can also overwrite the file in place, upload it half-written, or fork it into conflicted copies, and nothing inside DID can see those. Add a "Where to keep the database file" section to docs/sqlitedb.md: - what each of those does; - what DID does and doesn't catch; - how to share or back up a database safely (close it, then copy the .sqlite file and its files/ directory together). Point to it from the SQLiteDB docstring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Dn4gCNCU2jUGdmfPVCAGK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #94, docs only, no behaviour change.
#94 catches a database file that is replaced during a write. Sync clients (Dropbox, OneDrive, iCloud Drive, Google Drive) can also damage an open database in ways nothing inside DID can see:
Changes
docs/sqlitedb.mdgets a new section, "Where to keep the database file". It covers:files/directory, outside sync-managed folders;db.close()in every process, then copy the.sqlitefile andfiles/together.SQLiteDBdocstring: a short version of the same advice, pointing to that section.Locally:
black --check,ruff check,pytest(800 passed) andcheck_bridge_coverage.py(0 problems).Generated by Claude Code